Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(details): added name attribute entry #20861

Merged
merged 8 commits into from
Oct 13, 2023
Merged

docs(details): added name attribute entry #20861

merged 8 commits into from
Oct 13, 2023

Conversation

mfranzke
Copy link
Contributor

@mfranzke mfranzke commented Oct 2, 2023

Summary

Added new name-attribute to details elements, which enable an exclusive details element in a grouped list to be open (also known as accordion).

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Oct 2, 2023
@mfranzke mfranzke marked this pull request as ready for review October 6, 2023 05:01
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry for being slow.
Do you want to add https://bugzil.la/1856460 for Firefox?

@mfranzke
Copy link
Contributor Author

Thanks and sorry for being slow. Do you want to add https://bugzil.la/1856460 for Firefox?

loving it, missed that one (seems to me that it has been opened after I opened this issue); thank you !

@mfranzke mfranzke requested a review from Elchi3 October 13, 2023 11:39
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick follow-up!
(And Hi! I think we met some years ago at Write The Docs Prague!?)

@Elchi3 Elchi3 merged commit d147397 into mdn:main Oct 13, 2023
4 checks passed
@mfranzke mfranzke deleted the patch-2 branch October 13, 2023 11:56
@mfranzke
Copy link
Contributor Author

mfranzke commented Oct 13, 2023

Thanks for the quick follow-up! (And Hi! I think we met some years ago at Write The Docs Prague!?)

Sadly not, but I'll be at w-jax, FOSDEM, beyond tellerrand, CSS Day, UXcamp europe and probably WeAreDevelopers again, so there might be the chance for the future to meet at some of those in or around Germany.

Elchi3 pushed a commit to Elchi3/browser-compat-data that referenced this pull request Nov 14, 2023
* docs(details): added `name` attribute entry

* Update details.json

* Update details.json

* fix: eslint message

* docs: added firefox impl_url

thanks to @Elchi3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants