Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ts/detours): add data-fs-element properties to detours flow #2881

Merged
merged 8 commits into from
Oct 25, 2024

Conversation

firestack
Copy link
Member

@firestack firestack commented Oct 24, 2024

@firestack firestack marked this pull request as ready for review October 24, 2024 16:10
@firestack firestack requested a review from a team as a code owner October 24, 2024 16:10
Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Love how much use we can get out of data-fs-element for our needs.

Would it be good to write a list of the elements and their action and share them with the rest of the product team to verify these names are ideal, or we can skip that and just tweak it later based on feedback?

Example:
Activate detour button in confirmation modal: "Confirm Activate Detour"
Start detour button, to open confirmation modal: "Begin Activate Detour"

Might be best just to ship and tweak based on feedback

@firestack
Copy link
Member Author

Looks good to me! Love how much use we can get out of data-fs-element for our needs.

Would it be good to write a list of the elements and their action and share them with the rest of the product team to verify these names are ideal, or we can skip that and just tweak it later based on feedback?

Example: Activate detour button in confirmation modal: "Confirm Activate Detour" Start detour button, to open confirmation modal: "Begin Activate Detour"

Might be best just to ship and tweak based on feedback

We can do this in fullstory. As long as we keep the name the same, the selector can be renamed and described in fullstory.

@firestack firestack enabled auto-merge (squash) October 25, 2024 12:32
@firestack firestack merged commit 9f486ae into main Oct 25, 2024
39 checks passed
@firestack firestack deleted the kf/asn/detours-fs-elements branch October 25, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants