-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ts/detours): add data-fs-element
properties to detours flow
#2881
Conversation
effba10
to
4c7ceb2
Compare
4c7ceb2
to
8745bad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Love how much use we can get out of data-fs-element for our needs.
Would it be good to write a list of the elements and their action and share them with the rest of the product team to verify these names are ideal, or we can skip that and just tweak it later based on feedback?
Example:
Activate detour button in confirmation modal: "Confirm Activate Detour"
Start detour button, to open confirmation modal: "Begin Activate Detour"
Might be best just to ship and tweak based on feedback
We can do this in fullstory. As long as we keep the name the same, the selector can be renamed and described in fullstory. |
Asana Ticket: https://app.asana.com/0/1203014709808707/1208610656881565/f
Superceeds: #2870