feat(ts/components/vehicleMarker): implement shuttle colors #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
changed the base branch from
main
to
kf/refactor/vehicle-marker-file
firestack
force-pushed
the
kf/asn/shuttle-colors
branch
3 times, most recently
from
0e897ea
to
9b51abc
Compare
firestack
force-pushed
the
kf/asn/shuttle-colors
branch
from
9b51abc
to
cb426a0
Compare
firestack
changed the title
firestack
force-pushed
the
kf/asn/shuttle-colors
branch
2 times, most recently
from
4868252
to
439283c
Compare
firestack
force-pushed
the
kf/asn/shuttle-colors
branch
from
439283c
to
142409d
Compare
firestack
force-pushed
the
kf/asn/shuttle-colors
branch
from
142409d
to
74f9c17
Compare
hannahpurcell
requested changes
Oct 21, 2024
An error occurred while trying to automatically change base from
kf/refactor/vehicle-marker-file
to
main
October 21, 2024 12:41
firestack
force-pushed
the
kf/asn/shuttle-colors
branch
from
74f9c17
to
7a0dd0a
Compare
firestack
force-pushed
the
kf/asn/shuttle-colors
branch
from
7a0dd0a
to
f78ae95
Compare
firestack
force-pushed
the
kf/asn/shuttle-colors
branch
from
f78ae95
to
7e7e5bd
Compare
Right now if you were to pull out the icons into their own components, they wouldn't render correctly, so this fixes that the styling doesn't care if it's in a leaflet map or not.
firestack
force-pushed
the
kf/asn/shuttle-colors
branch
from
7e7e5bd
to
107fabf
Compare
The `RunId` => `ShuttleVariant` relationship is "many to one", which makes this better suited for a function which returns the enum value from the `RunId`.
firestack
force-pushed
the
kf/asn/shuttle-colors
branch
from
107fabf
to
ff11f18
Compare
hannahpurcell
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Ticket: https://app.asana.com/0/1203014709808707/1208457579513721/f
Depends on: