-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move and style copyButton, add to active and past detour views #2852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
reviewed
Oct 18, 2024
firestack
reviewed
Oct 18, 2024
firestack
reviewed
Oct 18, 2024
firestack
reviewed
Oct 18, 2024
hannahpurcell
force-pushed
the
hp/update-copy-details
branch
from
October 21, 2024 12:46
08f20b5
to
f443fef
Compare
firestack
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add yourself to the copy-button user group to see this on the active / past detour views, because I haven't yet done the copy logic.
The button will be visible on the View Draft Detour panel without being added to the user group.
Now depends on:
^ only because the copy change will prevent the button from being too cramped on the "View Draft Detour" page