Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Run database migrations before starting anything else #2730

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Run database migrations before starting anything else #2730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/skate/application.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ defmodule Skate.Application do
[]
end ++
[
Skate.Migrate,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that maybe this needs to be done before the Endpoint is started, but does it need to come before the PubSub?

Also, when would code in the Endpoint conflict with the Migrations? I assume this would never happen in a deployment due to our health checks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically I was thinking that code in the Endpoint would refer to some column in the database that's introduced in a migration. That'll cause an error in the

Do the healthchecks fail if there are any un-run migrations?

My reason for this was remembering that a while ago, when I added a migration, I was asked to pull the migration out to a pre-PR that got deployed before the main PR was merged. Maybe that wasn't necessary though?

{Phoenix.PubSub, name: Skate.PubSub},
SkateWeb.Endpoint,
Skate.Migrate,
{Oban, Application.fetch_env!(:skate, Oban)},
{Skate.Detours.TripModificationPublisher,
Application.get_env(:skate, Skate.Detours.TripModificationPublisher)}
Expand Down
Loading