feat(ts/hooks/usePanelState): add setTabMode API
#2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage of commit
|
lemald
reviewed
Nov 13, 2023
lemald
reviewed
Nov 13, 2023
firestack
force-pushed
the
kf/asn/panel-behaviour-search-maps-tab-mode
branch
from
0fde39e
to
13d4676
Compare
Coverage of commit
|
lemald
approved these changes
Nov 13, 2023
lemald
reviewed
Nov 13, 2023
firestack
force-pushed
the
kf/asn/panel-behaviour-search-maps
branch
from
0d1a0e0
to
413d98d
Compare
firestack
force-pushed
the
kf/asn/panel-behaviour-search-maps-tab-mode
branch
from
0ad7fb7
to
1bf2b0a
Compare
Coverage of commit
|
lemald
approved these changes
Nov 14, 2023
Coverage of commit
|
Base automatically changed from
kf/asn/panel-behaviour-search-maps
to
master
November 14, 2023 16:33
firestack
force-pushed
the
kf/asn/panel-behaviour-search-maps-tab-mode
branch
from
4ec131b
to
209a255
Compare
Coverage of commit
|
…ovide stateful version
…on` from props it can be added back later and it's more difficult to get a value out of it.
…nd close panel props
firestack
force-pushed
the
kf/asn/panel-behaviour-search-maps-tab-mode
branch
from
73b4aa6
to
5a62bb3
Compare
Coverage of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #2273, I ended up breaking the MapPage feature which allowed opening the VPP to a specific page. I considered adding the first part of this PR in #2273, but I figured it was getting large enough it'd be easier to digest as a separate PR.
This "stores" the state of the active VPP Tab in the
usePanelState*hooks because theinitialTabprop was insufficient because switching pages wouldn't reset the state oftabMode, thereforeinitialStatewas only respected once. By pulling the state out into the panel state, the tab can now be remembered across pages, and each page has it's own tab mode.Depends On: #2273
Asana Ticket: https://app.asana.com/0/1148853526253420/1205762199809559/f