fix(ts/components/NearbyStops): refresh stops when inputs to function change #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage of commit
|
lemald
reviewed
Oct 13, 2023
lemald
reviewed
Oct 13, 2023
|
@firestack general question: do you think it would be possible to write a test for this? |
I think so, I'll look into it this morning. Edit: this turned out to be very difficult to test because the nearby stops component is an implementation detail of MapDisplay. This bug requries that nearby stops are shown, that a route is the selected entity, and that the follower is off. Because of all this, it's difficult to get the follower to turn off, and to ensure that all the nearby stops are on screen, because nearby stops is essentially a marker culler, so markers are required to be within the screen bounds, which changes as you zoom in. |
… change Asana Ticket: [⚙️🐞 When selected route direction changes excluded nearby bus stops do not update](https://app.asana.com/0/1148853526253420/1205560497394206/f)
Co-authored-by: Eddie Maldonado <[email protected]>
firestack
force-pushed
the
kf/asn/fix-nearby-stop-exclusions
branch
from
1395a71
to
5b40eaa
Compare
Coverage of commit
|
Coverage of commit
|
lemald
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Ticket: ⚙️🐞 When selected route direction changes excluded nearby bus stops do not update