Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Halloween Skate logo and invalid buses as bats #1314

Merged
merged 7 commits into from
Oct 30, 2024
Merged

Halloween Skate logo and invalid buses as bats #1314

merged 7 commits into from
Oct 30, 2024

Conversation

dks-mbta
Copy link
Contributor

No description provided.

@dks-mbta dks-mbta requested a review from lemald October 29, 2021 18:13
@dks-mbta
Copy link
Contributor Author

Like last time, tests don't account for rendering differences on Halloween.

@github-actions
Copy link

Coverage of commit 63c0b2a

Summary coverage rate:
  lines......: 94.5% (2293 of 2426 lines)
  functions..: 68.8% (982 of 1428 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

lemald
lemald previously approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@lemald lemald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦇

@lemald lemald temporarily deployed to dev October 29, 2021 18:43 Inactive
@hannahpurcell hannahpurcell requested a review from a team as a code owner October 30, 2024 17:36
@hannahpurcell hannahpurcell dismissed lemald’s stale review October 30, 2024 19:08

Reviewed 3 years ago; has been updated with new Skate visuals

@hannahpurcell
Copy link
Collaborator

hannahpurcell commented Oct 30, 2024 •
edited
Loading

Some screenshots with the latest updates

Screenshot 2024-10-30 at 12 41 08 PM

@hannahpurcell
Copy link
Collaborator

And proof that regular Sk8 still looks regular

Screenshot 2024-10-30 at 3 51 27 PM
Screenshot 2024-10-30 at 3 51 35 PM

@hannahpurcell hannahpurcell merged commit 9fb7e8f into main Oct 30, 2024
45 checks passed
@hannahpurcell hannahpurcell deleted the dks-halloween branch October 30, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahpurcell hannahpurcell hannahpurcell left review comments

@firestack firestack firestack approved these changes

@joshlarson joshlarson joshlarson left review comments

@lemald lemald lemald left review comments

Assignees

@firestack firestack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dks-mbta @hannahpurcell @joshlarson @lemald @firestack