fix(useLimitedSearchResults): Don't subscribe to topic when query is …

…empty (#2187) * fix(useLimitedSearchResults): Don't subscribe to topic when query is empty * Update assets/tests/hooks/useSearchResults.test.ts Co-authored-by: Kayla Firestack <[email protected]> --------- Co-authored-by: Kayla Firestack <[email protected]>
mbta · Aug 16, 2023 · baf9663 · baf9663
1 parent 6debd51
commit baf9663
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/assets/src/hooks/useSearchResults.ts b/assets/src/hooks/useSearchResults.ts
@@ -62,7 +62,9 @@ export const useLimitedSearchResults = (
   query: { property: VehiclePropertyQuery; text: string; limit: number } | null
 ): Ok<LimitedSearchResults<Vehicle | Ghost>> | Loading | null => {
   const topic: string | null =
-    query && `vehicles_search:limited:${query.property}:${query.text}`
+    query?.text && query.text != ""
+      ? `vehicles_search:limited:${query.property}:${query.text}`
+      : null
 
   const [state, pushUpdate] = useCheckedTwoWayChannel<
     LimitedSearchResultsData,

diff --git a/assets/tests/hooks/useSearchResults.test.ts b/assets/tests/hooks/useSearchResults.test.ts
@@ -302,6 +302,20 @@ describe("useLimitedSearchResults", () => {
     )
     expect(result.current).toEqual(null)
   })
+
+  test("when no query is for empty string, returns null", () => {
+    const mockSocket = makeMockSocket()
+
+    const { result } = renderHook(() =>
+      useLimitedSearchResults(mockSocket, {
+        text: "",
+        property: "run",
+        limit: 5,
+      })
+    )
+    expect(result.current).toEqual(null)
+  })
+
   test("initializing the hook subscribes to the search results", () => {
     const mockSocket = makeMockSocket()
     const mockChannel = makeMockChannel("ok")