Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use less jquery #729

Merged
merged 31 commits into from
Nov 5, 2023
Merged

Use less jquery #729

merged 31 commits into from
Nov 5, 2023

Conversation

mbraak
Copy link
Owner

@mbraak mbraak commented Aug 6, 2023

Use browser apis instead of jquery where possible. Some of these api calls are not available on old browsers like ie11.

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (45217fb) 90.85% compared to head (a8df0ed) 90.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #729      +/-   ##
==========================================
- Coverage   90.85%   90.57%   -0.29%     
==========================================
  Files          22       28       +6     
  Lines        2219     2227       +8     
  Branches      617      619       +2     
==========================================
+ Hits         2016     2017       +1     
- Misses        203      210       +7     
Files Coverage Δ
src/dragAndDropHandler/visibleNodeIterator.ts 100.00% <100.00%> (ø)
src/keyHandler.ts 98.18% <100.00%> (-0.07%) ⬇️
src/util.ts 100.00% <100.00%> (ø)
src/dragAndDropHandler/index.ts 83.33% <92.30%> (ø)
src/elementsRenderer.ts 96.07% <75.00%> (-0.57%) ⬇️
src/dragAndDropHandler/dragElement.ts 85.71% <85.71%> (ø)
src/dragAndDropHandler/hitAreasGenerator.ts 97.05% <97.05%> (ø)
src/tree.jquery.ts 93.33% <87.50%> (-0.49%) ⬇️
src/nodeElement/folderElement.ts 90.38% <90.38%> (ø)
src/nodeElement/index.ts 83.78% <83.78%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Aug 12, 2023

Size Change: +490 B (+2%)

Total Size: 26.8 kB

Filename Size Change
./lib/dragAndDropHandler.js 0 B -3.32 kB (removed) 🏆
./lib/elementsRenderer.js 1.73 kB +29 B (+2%)
./lib/keyHandler.js 698 B -23 B (-3%)
./lib/nodeElement.js 0 B -1.47 kB (removed) 🏆
./lib/scrollHandler/scrollParent.js 0 B -1.36 kB (removed) 🏆
./lib/tree.jquery.js 5.56 kB +18 B (0%)
./lib/util.js 282 B +58 B (+26%) 🚨
./lib/dragAndDropHandler/dragElement.js 361 B +361 B (new file) 🆕
./lib/dragAndDropHandler/hitAreasGenerator.js 1.04 kB +1.04 kB (new file) 🆕
./lib/dragAndDropHandler/index.js 2.09 kB +2.09 kB (new file) 🆕
./lib/dragAndDropHandler/visibleNodeIterator.js 608 B +608 B (new file) 🆕
./lib/nodeElement/borderDropHint.js 386 B +386 B (new file) 🆕
./lib/nodeElement/folderElement.js 835 B +835 B (new file) 🆕
./lib/nodeElement/ghostDropHint.js 527 B +527 B (new file) 🆕
./lib/nodeElement/index.js 710 B +710 B (new file) 🆕
ℹ️ View Unchanged
Filename Size
./lib/dataLoader.js 818 B
./lib/jqtreeOptions.js 33 B
./lib/mouse.widget.js 1.17 kB
./lib/node.js 3.42 kB
./lib/nodeUtils.js 194 B
./lib/saveStateHandler.js 1.48 kB
./lib/scrollHandler.js 473 B
./lib/scrollHandler/containerScrollParent.js 874 B
./lib/scrollHandler/createScrollParent.js 546 B
./lib/scrollHandler/documentScrollParent.js 1.04 kB
./lib/scrollHandler/types.js 33 B
./lib/selectNodeHandler.js 752 B
./lib/simple.widget.js 947 B
./lib/types.js 33 B
./lib/version.js 147 B

compressed-size-action

@mbraak mbraak merged commit 04280df into dev Nov 5, 2023
4 of 6 checks passed
@mbraak mbraak deleted the use-less-jquery branch November 5, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant