sandbox #1
Draft
sandbox #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
force-pushed
the
clone-build
branch
2 times, most recently
from
e18b4cd
to
637fd04
Compare
Repository owner
locked and limited conversation to collaborators
Feb 2, 2024
Repository owner
unlocked this conversation
Feb 2, 2024
mbien
force-pushed
the
clone-build
branch
2 times, most recently
from
dec9015
to
66d417d
Compare
mbien
force-pushed
the
clone-build
branch
3 times, most recently
from
e5282b5
to
a127123
Compare
FISH-7079 Copy compiled resources from classes directory to exploded binary PR review changes - inline return condition Constructor Signature update Remove log Add generic type
Fix Single-file-java-launcher test and add module to CI
Update ASM from 9.7 to 9.7.1
…ation_file_owner Making minor code modifications for better readability and validation
Support for Payara Server instance running on WSL
Removed changes in comments while renaming
Increment spec versions for Apache NetBeans 25 development
issue template: enable 24 rc selection
VSCode integration commands
….source.base
Fixed tests failures in the modules java.hints and java.source.base on
Windows due to CRLF-LF mismatches between the expected and actual
outputs.
1. *VanillaCompileWorkerTest.java*:
- transform `System.lineSeparator()` to LF on the actual outputs.
2. *TreeRuleTestBase.java*:
- change the "ignore whitespace" transformation of the actual output
to use `\\s+` instead of only tabs and LFs.
3. *.gitattributes*:
- Mark all test golden files i.e. expected outputs, in the
java.hints module to have only LF line endings.
- This aids tests extending *TreeRuleTestBase*
- Thanks to @mbien for guidance on this.
Signed-off-by: Siddharth Srinivasan <[email protected]>
…code_bug Fix code-folding for LSP clients that support line-folding only
Checking for null capabilities.
…_windows Fix tests failure due to CRLF mismatch on Windows in java.hints, java.source.base
The javac outputs of the following tests in java/java.hints ErrorHintsProviderTest were updated for non-mac OSes due to changes in JDK 7 updates: - testShortErrors5: [jdk-6968793](openjdk/jdk@b77effad6c6) - testTestShortErrorsSVUIDWarning: [jdk-6957438](openjdk/jdk@1c75e97108) Since Apple JDK was present only up till JDK 6, we no longer require the special case for MacOS since JDK 8. Thus, making the test argument value `specialMacTreatment = false` for these two tests, and renaming the corresponding goldenfiles from "-nonmac.pass" suffix to ".pass" suffix. Signed-off-by: Siddharth Srinivasan <[email protected]>
…s_javahints Fix MacOS tests failures in java.hints
mbien
force-pushed
the
clone-build
branch
2 times, most recently
from
7599da2
to
9d6735f
Compare
- simple script to check if all commits have proper email addresses - looks for empty or single word subject messages - can warn about missing blank line after subject (disabled) - logs errors/warnings to the github actions summary page, fails on error paperwork job: - the paperwork job will now no longer prevent the github workspace from being cleaned up on failure
mbien
force-pushed
the
clone-build
branch
2 times, most recently
from
b6c9ffc
to
341da28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.