Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problems with Ecore-Importer tests #2526

Merged
merged 23 commits into from
Sep 23, 2024
Merged

Fix problems with Ecore-Importer tests #2526

merged 23 commits into from
Sep 23, 2024

Conversation

kbirken
Copy link
Member

@kbirken kbirken commented Sep 19, 2024 •
edited
Loading

This fixes some problems with the Ecore-Importer tests:

  • all languages and solutions used by the tests are now part of the project and of the build script
  • the tests are now actually executed during the build
  • the tests now actually check if something goes wrong (before, only a little fraction of assertions had been tested)
  • reworked handling of enumeration attributes/properties by the exporter
  • removed references to deprecated enumeration concepts
  • some more clean-up (removed dependencies, moved modules to proper virtual folders, ...)

This PR solves #2522.

@kbirken kbirken self-assigned this Sep 19, 2024
@kbirken
Move test languages and utilities to proper virtual folders (issue #2522
27778d7 
).
@kbirken
Rename folder of an ecore test project, should have same name as msd-…
eb5aa2b 
…file (issue #2522).
@kbirken
Add first ecore-importer test project to test build (issue #2522).
69e8a79
@kbirken
Fix test build script (issue #2522).
f26b2c2
@kbirken
Improve model comparison during ecore metamodel tests (issue #2522).
02ecd7c 
The utility did not compare DataTypeDeclarations before.
@kbirken
Fix creation of enumerators during import (issue #2522).
1b8f93a
@kbirken
Fix more tests with expected enumerations (issue #2522).
bffb32c
@kbirken
Improve comparison util in test and fix all broken tests regarding me…
2a55e2d 
…tamodel import (issue #2522).
@kbirken
Improve handling of enumeration types by model exporter (issue #2522).
47f275e
@kbirken
Add dumping of intermediate xml files, useful for debugging (issue #2522
44695f9 
).
@kbirken
Update enum-related tests for model import/export (issue #2522).
d647a3c
@kbirken
Add second test module to test build script (issue #2522).
bf97ce3
@kbirken
Add two of the test languages to check if error vanishes (issue #2522).
c28196e
@kbirken
Remove empty generators of test languages 1-6 (issue #2522).
f7160cd
@kbirken
Add all test languages to test build script (issue #2522).
ef1369e
@kbirken
Add amalthea test language to test build script (issue #2522).
d5a57f3
@kbirken
Add another test case for language 2, in order to cover different def…
44824fc 
…ault-literal use cases (issue #2522).
@kbirken
Streamline import/export test code and add comments (issue #2522).
107f54e
@kbirken
Rename test model file (issue #2522).
13f8ccb
@kbirken
Remove unused dependencies (issue #2522).
3b9251c
@kbirken
Update CHANGELOG (issue #2522).
fe6c098
@kbirken kbirken marked this pull request as ready for review September 23, 2024 07:37
alexanderpann
alexanderpann approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@alexanderpann alexanderpann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! LGTM, the PR fixes the mentioned issue.

I've created a followup ticket for more cleanup tasks that I noticed: #2529 in case you work on the language again.

@sergej-koscejev
Copy link
Member

I believe @alexanderpann so I'm going to merge this without reviewing :) I'll let you know if any additional issues arise. Thanks!

@sergej-koscejev sergej-koscejev merged commit 901bd51 into maintenance/mps20223 Sep 23, 2024
1 check passed
@sergej-koscejev sergej-koscejev deleted the bugfix/fix_ecoreimporter_tests_2522 branch September 23, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderpann alexanderpann alexanderpann approved these changes

@sergej-koscejev sergej-koscejev Awaiting requested review from sergej-koscejev

@arimer arimer Awaiting requested review from arimer

Assignees

@kbirken kbirken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbirken @sergej-koscejev @alexanderpann