-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Decoder.js #62
base: master
Are you sure you want to change the base?
Conversation
Fixed to make it work on iOS Safari
Added splitting to NAL units to fix live streaming
@yarontorbaty about the self issue. how did you run into problems there?
non of those would produce a error. and how would it fix anything. if no global object exists the code should not work as intended. you provided 2 commits in the pr. the first is reasonable but the 2nd seems to be quite messy. could you please eather clean it up or remove the 2nd commit? |
My apologies, I'm a bit new to all of this. This is the error from the console when running in iOS Safari: http://81.94.238.95:8089/Broadway/Player/Decoder.js:25 Not sure why this is happening though. I cleaned up to code a bit and made a new commit. |
but does it run with the changes in your safari? |
Yes, it does. |
i need more information about this. |
How do I check that? |
Fixed to make video playing work on iOS Safari for BroadwayStream project by soliton4