Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Decoder.js #62

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

yarontorbaty
Copy link

Fixed to make video playing work on iOS Safari for BroadwayStream project by soliton4

Fixed to make it work on iOS Safari
Added splitting to NAL units to fix live streaming
@soliton4
Copy link
Collaborator

@yarontorbaty about the self issue. how did you run into problems there?
i can think of 2 scenarios:

  1. its used in the main thread then there is a window object
  2. its used in a worker. then there is a self object.

non of those would produce a error.

and how would it fix anything. if no global object exists the code should not work as intended.

you provided 2 commits in the pr. the first is reasonable but the 2nd seems to be quite messy. could you please eather clean it up or remove the 2nd commit?

@yarontorbaty
Copy link
Author

My apologies, I'm a bit new to all of this.

This is the error from the console when running in iOS Safari:

http://81.94.238.95:8089/Broadway/Player/Decoder.js:25
TypeError: undefined is not an object (near '...}else if (self != "undefined")...')

Not sure why this is happening though.

I cleaned up to code a bit and made a new commit.

@soliton4
Copy link
Collaborator

but does it run with the changes in your safari?

@yarontorbaty
Copy link
Author

Yes, it does.

@soliton4
Copy link
Collaborator

i need more information about this.
what is the name of the global object in the browser that has the issue

@yarontorbaty
Copy link
Author

How do I check that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants