implement recv_raw
for Connection wrappers into mavlink-core
#605
Annotations
2 errors and 6 warnings
Run actions-rs-plus/clippy-check@v2:
mavlink-core/src/async_connection/udp.rs#L185
error: this loop never actually loops
--> mavlink-core/src/async_connection/udp.rs:185:9
|
185 | / loop {
186 | | #[cfg(not(feature = "signing"))]
187 | | let result = match self.protocol_version {
188 | | MavlinkVersion::V1 => MAVLinkRawMessage::V1(
... |
213 | | return Ok(result);
214 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
note: the lint level is defined here
--> mavlink-core/src/lib.rs:23:9
|
23 | #![deny(clippy::all)]
| ^^^^^^^^^^^
= note: `#[deny(clippy::never_loop)]` implied by `#[deny(clippy::all)]`
|
Run actions-rs-plus/clippy-check@v2
Clippy had exited with the 101 exit code
|
Run actions-rs-plus/clippy-check@v2:
mavlink-bindgen/src/parser.rs#L1367
warning: first doc comment paragraph is too long
--> mavlink-bindgen/src/parser.rs:1367:1
|
1367 | / /// CRC operates over names of the message and names of its fields
1368 | | /// Hence we have to preserve the original uppercase names delimited with an underscore
1369 | | /// For field names, we replace "type" with "mavtype" to make it rust compatible (this is
1370 | | /// needed for generating sensible rust code), but for calculating crc function we have to
1371 | | /// use the original name "type"
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
= note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
|
Run actions-rs-plus/clippy-check@v2:
mavlink-core/src/async_connection/mod.rs#L3
warning: unused import: `MAVLinkV2MessageRaw`
--> mavlink-core/src/async_connection/mod.rs:3:32
|
3 | use crate::{MAVLinkRawMessage, MAVLinkV2MessageRaw, MavFrame, MavHeader, MavlinkVersion, Message};
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
Run actions-rs-plus/clippy-check@v2:
mavlink-core/src/async_connection/tcp.rs#L6
warning: unused imports: `MAVLinkV2MessageRaw`, `read_v1_raw_message`, and `read_v2_raw_message_async`
--> mavlink-core/src/async_connection/tcp.rs:6:5
|
6 | read_v1_raw_message, read_v1_raw_message_async, read_v2_raw_message_async,
| ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^
7 | read_v2_raw_message_async_signed, MAVLinkRawMessage, MAVLinkV2MessageRaw, MavHeader,
| ^^^^^^^^^^^^^^^^^^^
|
Run actions-rs-plus/clippy-check@v2:
mavlink-core/src/async_connection/udp.rs#L13
warning: unused imports: `MAVLinkV2MessageRaw` and `read_v2_raw_message_async`
--> mavlink-core/src/async_connection/udp.rs:13:68
|
13 | async_peek_reader::AsyncPeekReader, read_v1_raw_message_async, read_v2_raw_message_async,
| ^^^^^^^^^^^^^^^^^^^^^^^^^
14 | read_v2_raw_message_async_signed, MAVLinkRawMessage, MAVLinkV2MessageRaw, MavHeader,
| ^^^^^^^^^^^^^^^^^^^
|
Run actions-rs-plus/clippy-check@v2:
mavlink-core/src/async_connection/direct_serial.rs#L10
warning: unused imports: `MAVLinkV2MessageRaw` and `read_v2_raw_message_async`
--> mavlink-core/src/async_connection/direct_serial.rs:10:68
|
10 | async_peek_reader::AsyncPeekReader, read_v1_raw_message_async, read_v2_raw_message_async,
| ^^^^^^^^^^^^^^^^^^^^^^^^^
11 | read_v2_raw_message_async_signed, MAVLinkRawMessage, MAVLinkV2MessageRaw, MavHeader,
| ^^^^^^^^^^^^^^^^^^^
|
Run actions-rs-plus/clippy-check@v2:
mavlink-core/src/async_connection/file.rs#L10
warning: unused imports: `MAVLinkV2MessageRaw` and `read_v2_raw_message_async`
--> mavlink-core/src/async_connection/file.rs:10:32
|
10 | read_v1_raw_message_async, read_v2_raw_message_async, read_v2_raw_message_async_signed,
| ^^^^^^^^^^^^^^^^^^^^^^^^^
11 | MAVLinkRawMessage, MAVLinkV2MessageRaw,
| ^^^^^^^^^^^^^^^^^^^
|
Loading