WIP: Add possibility of showing usernames for items #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, usernames could be visible just for duplicate items, however it might be useful to see them for unique items too. Flag '--show-username' has been added to allow for such functionality
|
Part of the code introduced increases the time it takes to start the window by 3.5-4 seconds. I am currently investigation why and ways to reduce it. In its current state, I would advise against merging the pull request. |
mattydebie
changed the title
|
Thanks for taking the time to create and investigate this PR! Looking forward to the result |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, usernames could be visible just for duplicate items, however it might be useful to see them for unique items too. Flag '--show-username' has been added to allow for such functionality.
This functionality however adds a dependency for Bash 4.0. But considering that this version of Bash has been released in 2009, I wouldn't consider this to be an issue.