Changes while I wrote an indexer #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Some TLC for the crate: * Convert writes to byte slices * Replace pervasive matches with ? * Use Result::map operator for conversions * Reformat with "cargo +stable fmt" * Read from bufstream, use lines helper where appropriate * Binaries (#3) * Messy work, but we can auth with TLS and passwords * Pipeline article reading works * GZIP (#2) * Let's see what happens * tackled all the warnings, converted to a custom error type * Looking much better for parsing headers * More goodies * snagging headers * GitHub actions (#1) * does it build * let's use nightly * BufStream helper * whack-a-mole with errors I left hanging around * Not sure what's going on with this old code * I think it's happy again * Clippy run, go clippy go * cargo test warnings go away
* Some TLC for the crate: * Convert writes to byte slices * Replace pervasive matches with ? * Use Result::map operator for conversions * Reformat with "cargo +stable fmt" * Read from bufstream, use lines helper where appropriate * Binaries (#3) * Messy work, but we can auth with TLS and passwords * Pipeline article reading works * GZIP (#2) * Let's see what happens * tackled all the warnings, converted to a custom error type * Looking much better for parsing headers * More goodies * snagging headers * GitHub actions (#1) * does it build * let's use nightly * BufStream helper * whack-a-mole with errors I left hanging around * Not sure what's going on with this old code * I think it's happy again * Clippy run, go clippy go * cargo test warnings go away
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experimenting with this library to build an indexer.
I've just been merging in to my master branch so it's a big ball of changes. But I wanted to float this past you so you could see how all this is coming together.
I couldn't figure out how to recombobulate binary groups to make sense of articles so this work just kind of came to a pause