Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: render channel links in threads list #8205

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

space-w-alker
Copy link

fixes: mattermost/mattermost#27859

Summary

Add channel links to the threads list.

Ticket Link

Fixes mattermost/mattermost#27859
Jira https://mattermost.atlassian.net/browse/MM-58314

Checklist

  • Has UI changes
  • Have tested against the 5 core themes to ensure consistency between them.

Device Information

This PR was tested on: Android Emulator, Android 12

Screenshots

Before:
before_changes

After:
after_changes

Release Note

Added channel links to threads list

@mm-cloud-bot mm-cloud-bot added kind/bug Categorizes issue or PR as related to a bug. release-note labels Sep 6, 2024
@mattermost-build
Copy link
Contributor

Hello @space-w-alker,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@space-w-alker
Copy link
Author

/check-cla

@rahimrahman
Copy link
Contributor

Hi @space-w-alker -- thank you for your first contribution and fix. I'll help review this with my colleagues.

Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 🎉

@rahimrahman rahimrahman added the 3: QA Review Requires review by a QA tester label Sep 13, 2024
@rahimrahman rahimrahman added the Build Apps for PR Build the mobile app for iOS and Android to test label Sep 13, 2024
@lindy65 lindy65 requested review from yasserfaraazkhan and removed request for lindy65 September 13, 2024 15:12
@rahimrahman rahimrahman removed the Build Apps for PR Build the mobile app for iOS and Android to test label Sep 13, 2024
@yasserfaraazkhan
Copy link
Contributor

/update-branch

@yasserfaraazkhan yasserfaraazkhan added the Build App for iOS Build the mobile app for iOS label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: QA Review Requires review by a QA tester Build App for iOS Build the mobile app for iOS Contributor kind/bug Categorizes issue or PR as related to a bug. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RN: Threads list doesn't show channel links
6 participants