Fix user autocomplete not showing users not in channel #7980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larkox
added
2: Dev Review
lindy65
added
the
Build Apps for PR
enahum
approved these changes
May 31, 2024
lindy65
approved these changes
May 31, 2024
There was a problem hiding this comment.
Thanks @larkox - this is fixed. I can see users who are not members of the channel.
Noting: the users who are not in channel are not displayed in a separate section headed NOT IN CHANNEL as is the case on webapp
If we are happy with this discrepancy, I'm approving
lindy65
added
QA Review Done
and removed
3: QA Review
amyblais
added
the
CherryPick/Approved
hmhealey
approved these changes
May 31, 2024
hmhealey
added
4: Reviews Complete
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
that referenced
this pull request
May 31, 2024
(cherry picked from commit 9628e15)
mattermost-build
added
CherryPick/Done
enahum
pushed a commit
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were always getting the users from the database on user autocomplete, which may not have all the information.
We fix that by appending at the end the rest of the users received from the API.
Ticket Link
https://mattermost.atlassian.net/browse/MM-58504
Release Note
Issue introduced probably by #7506 , which (I think) never made it to production.