Fix user autocomplete not always showing on search screen #7977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larkox
added
2: Dev Review
enahum
approved these changes
May 30, 2024
devinbinnie
approved these changes
May 30, 2024
amyblais
added
the
CherryPick/Approved
lindy65
added
the
Build Apps for PR
lindy65
approved these changes
May 30, 2024
lindy65
added
4: Reviews Complete
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
that referenced
this pull request
May 31, 2024
(cherry picked from commit 663f9ba)
mattermost-build
added
CherryPick/Done
larkox
added a commit
that referenced
this pull request
May 31, 2024
) (cherry picked from commit 663f9ba) Co-authored-by: Daniel Espino García <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #7506 we changed the behavior of the user autocomplete. Among other things, we made an async call where there was no async call, and we were not waiting for it, causing the
loadingstate setting back to false before setting the users. This let the autocomplete think there are no results to show.Awaiting that line solves the issue.
Ticket Link
Fix https://mattermost.atlassian.net/browse/MM-58493
Release Note
I think the offending PR has not yet being released. If it has been released, then the release note should show:
Fix issue where the user autocomplete doesn't show in the search screen on some circumstances