Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-57291] Calls: Add channel name to call header #7968

Merged
merged 1 commit into from
May 24, 2024
Merged

[MM-57291] Calls: Add channel name to call header #7968

merged 1 commit into from
May 24, 2024

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented May 23, 2024

Summary

Ticket Link

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.

Device Information

  • Android: 13, Pixel 6
  • Android: 13, Galaxy Tab s7+
  • iOS: 16.5.1, iPhone 14

Screenshots

Release Note

Calls: Add channel name to call header

@cpoile cpoile added 2: Dev Review Requires review by a core commiter 2: UX Review Requires review by a UX Designer labels May 23, 2024
matthewbirtch
matthewbirtch approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@matthewbirtch matthewbirtch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@matthewbirtch matthewbirtch removed the 2: UX Review Requires review by a UX Designer label May 24, 2024
@streamer45 streamer45 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels May 24, 2024
@cpoile cpoile merged commit 5e1c75f into main May 24, 2024
16 checks passed
@cpoile cpoile deleted the MM-57291-call-header branch May 24, 2024 17:50
@amyblais amyblais added this to the v2.18.0 milestone May 24, 2024
larkox pushed a commit to larkox/mattermost-mobile that referenced this pull request May 30, 2024
@cpoile @larkox
[MM-57291] Calls: Add channel name to call header (mattermost#7968)
50e01e3
@amyblais amyblais added the Docs/Needed Requires documentation label May 31, 2024
@amyblais amyblais removed the Docs/Needed Requires documentation label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enahum enahum enahum approved these changes

@matthewbirtch matthewbirtch matthewbirtch approved these changes

@streamer45 streamer45 streamer45 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request release-note
Projects
None yet
Milestone
v2.18.0
Development

Successfully merging this pull request may close these issues.
6 participants
@cpoile @streamer45 @matthewbirtch @enahum @amyblais @mm-cloud-bot