MM-54199 - attachment author name missing on mobile

[pvev]

Summary

There was a small display issue with the author name in the matterpoll attachment in mobile view posts. This PR makes sure to display the author name either the icon is provided or not.

Ticket Link

https://mattermost.atlassian.net/browse/MM-54199

Checklist

• [X ] Added or updated unit tests (required for all new features)
• [ X] Has UI changes
• Includes text changes and localization file updates
• [X ] Have tested against the 5 core themes to ensure consistency between them.

Device Information

This PR was tested on:

Screenshots

Before:

After:

Release Note

NONE

[larkox]

Great!

[pvev]

@DHaussermann friendly reminder on this one :) . Thanks!

[DHaussermann]

/update-branch

[mattermost-build]

Building app in separate branch.

[DHaussermann]

@pvev maybe I've misunderstood something here but, I don't see a change. The authors name is still not visible in the post attachment data when I view it with the mobile client. I also used the Matterpoll example.

I tested this on Android (iOS testing is blocked for me for reasons unrelated to this PR) as follows:

• On community open the test public channel and created a poll with /poll
• Noted the authors' name shown in the attachment when viewed in the webapp
• Downloaded this build for PR from the Mobile: Test Builds channel and side-loaded it onto my Android device
• Launched MM Beta app and connected the app to Community server
• Observed the post created in test channel above
• Created a 2nd poll from the mobile app for fun to see if the post would look any different
  Observed: The author is still not shown

I using a Samsung Galaxy S22 running Android 13 with the stock One UI 5.1 launcher.

[DHaussermann]

Sorry @pvev, we can ignore the comment above ☝️
I don't know how but, I seem to have been having a deployment issue earlier.

After repeating the steps and side-loading the app again I can see your change 🎉

Testing is ongoing - I'm still trying to get my iOS device working with test builds. I will post an update on this shortly.

[DHaussermann]

Tested and passed.
Tested with /poll as it provides the case where there is an author but no icon

• I see this working as expected.
• When there is no author_icon the post author is still visible in the post content on mobile
• Tested on Androis and iOS

LGTM!

Thanks @pvev for helping troubleshoot my deployment issue on this one 👍