CLD-4642 Add support for SLO metric checks while in soaking state #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stylianosrigas
requested review from
stafot,
andrleite and
angeloskyratzakos
internal/elrond/elrond_soak.go
Outdated
Comment on lines
33
to
35
| if err != nil { | ||
| return errors.Wrap(err, "failed to query thanos") | ||
| } |
There was a problem hiding this comment.
this should be higher otherwise the for loop will break, right?
There was a problem hiding this comment.
this should be higher otherwise the for loop will break, right?
Nice catch thanks dude
angeloskyratzakos
approved these changes
Sep 11, 2023
added 9 commits
September 11, 2023 17:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary