Fix SLO metric for soaking by adding or vector(0) (#28)

mattermost · Jan 29, 2024 · bd0cccd · bd0cccd
1 parent dc8c9a2
commit bd0cccd
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/internal/elrond/elrond_soak.go b/internal/elrond/elrond_soak.go
@@ -48,7 +48,7 @@ func querySLOMetrics(ring *model.Ring, url string, queryTime time.Time, logger *
 	defer cancel()
 	var results []pmodel.Vector
 	for _, installationGroup := range ring.InstallationGroups {
-		query := fmt.Sprintf("((slo:sli_error:ratio_rate5m{slo_service='%[1]s-ring-%[2]s'} > (14.4 * 0.005)) and ignoring(slo_window)(slo:sli_error:ratio_rate1h{slo_service='%[1]s-ring-%[2]s'} > (14.4 * 0.005))) or ignoring(slo_window)((slo:sli_error:ratio_rate30m{slo_service='%[1]s-ring-%[2]s'} > (6 * 0.005)) and ignoring(slo_window)(slo:sli_error:ratio_rate6h{slo_service='%[1]s-ring-%[2]s'} > (3.3 * 0.005)))", installationGroup.Name, installationGroup.ProvisionerGroupID)
+		query := fmt.Sprintf("((slo:sli_error:ratio_rate5m{slo_service='%[1]s-ring-%[2]s'} > (14.4 * 0.005)) and ignoring(slo_window)(slo:sli_error:ratio_rate1h{slo_service='%[1]s-ring-%[2]s'} > (14.4 * 0.005))) or ignoring(slo_window)((slo:sli_error:ratio_rate30m{slo_service='%[1]s-ring-%[2]s'} > (6 * 0.005)) and ignoring(slo_window)(slo:sli_error:ratio_rate6h{slo_service='%[1]s-ring-%[2]s'} > (3.3 * 0.005))) or vector(0)", installationGroup.Name, installationGroup.ProvisionerGroupID)
 		result, warnings, err := v1api.Query(ctx, query, queryTime)
 		if err != nil {
 			return nil, errors.Wrap(err, "failed to query")