Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory can have spaces in its name #3198

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

andr-sokolov
Copy link
Contributor

No description provided.

@mm-cloud-bot
Copy link

@andr-sokolov: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@mattermost-build
Copy link
Contributor

Hello @andr-sokolov,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@devinbinnie
Copy link
Member

@andr-sokolov Thanks for the PR! Once you sign the CLA above I can take review and merge.

@andr-sokolov
Copy link
Contributor Author

@andr-sokolov Thanks for the PR! Once you sign the CLA above I can take review and merge.

@devinbinnie, I can't open the CLA. I get the "403 Forbidden" message.
изображение

@devinbinnie
Copy link
Member

@andr-sokolov Works for me. I'll ask internally to see if anyone sees what you're seeing.

@andr-sokolov
Copy link
Contributor Author

/check-cla

@andr-sokolov
Copy link
Contributor Author

@andr-sokolov Works for me. I'll ask internally to see if anyone sees what you're seeing.

@devinbinnie, I have signed the CLA

Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straight-forward. Thanks @andr-sokolov :)

@devinbinnie devinbinnie added the 2: Dev Review Requires review by a core committer label Nov 11, 2024
@devinbinnie devinbinnie merged commit cd2d5e8 into mattermost:master Nov 12, 2024
36 of 37 checks passed
@amyblais amyblais added this to the v5.11.0 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants