Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable full screen mode on Linux #3151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devinbinnie
Copy link
Member

Summary

We have made the decision to disable full screen mode on Linux, for a number of reasons:

  • Most notably, the buttons for minimize/maximize/restore/close are not able to be hidden on Linux, as per this Electron issue: [Feature Request]: Ability to hide titleBarOverlay electron/electron#43030. Under full screen mode on Windows, these are hidden automatically, but under Linux they remain. This behaviour would continue under native Linux titlebars.
  • Use of the above buttons consistently puts the window in a really weird state where the window is not in full screen mode, but it thinks it is and is stuck and not able to be moved or resized.
  • Every window manager handles the sizing and abilities of this window while it's in full screen mode, causing some inconsistencies that are impossible to account for.
  • When entering full screen mode, it is common for renderer artifacts to show up where either certain events aren't fired (causing buttons to appear in the wrong spot) or window elements are not visible or sized improperly. I've seen this on both X11 and Wayland.
  • It is too easy to accidentally enter full screen mode by accidentally pressing F11, which has caused some false positives around bugs.

The thinking is that this feature is not widely used, and can be mostly replicated by just maximizing the window, which only leaves some screen exclusivity as the one miss here.

I'll be willing to return this functionality if both
a) We find this is used by a number of users
b) Electron provides more stable APIs/workarounds for the issues we are experiencing.

Ticket Link

Closes #3143

Disable full screen mode on Linux

@devinbinnie devinbinnie added the 2: Dev Review Requires review by a core committer label Sep 20, 2024
@devinbinnie devinbinnie added this to the v5.10.0 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mattermost desktop app instance cannot be resized or moved on Ubuntu via UI
3 participants