[MM-60232] Fix a crash in Linux when trying to create a thumbnail from an image #3147
Conversation
| // Linux doesn't support the thumbnail creation so we have to use the base function | ||
| if (process.platform === 'linux') { | ||
| // We also will cap this at 1MB so as to not inflate the memory usage of the downloads dropdown | ||
| if (item.getReceivedBytes() < 1000000) { |
There was a problem hiding this comment.
please clarify
to not inflate the memory usage of the downloads
Does it mean if image size is greater than 1mb we wont show the preview in the download dropdown
There was a problem hiding this comment.
Correct. This is a bit of pre-emptive safety, but I did notice that if you do have a really large image stored in the JSON (like I had before) it will slow down the app significantly, so I want to avoid that.
There was a problem hiding this comment.
Since this is for images only dont we have access to preview url of the image?
There was a problem hiding this comment.
Not anymore, we can't use the file:/// protocol which would facilitate that. And we don't want to open up mattermost-desktop: to arbitrary files, or else security becomes a concern.
I'd be up for trying to figure out a better solution in the future, but this works for now.
devinbinnie
added
4: Reviews Complete
|
/cherry-pick release-5.9 |
|
Cherry pick is scheduled. |
mattermost-build
added
CherryPick/Done
…m an image (#3147) (#3149) * [MM-60232] Fix a crash in Linux when trying to create a thumbnail from an image * Fix lint * Cap at 1MB * Fix crash again (cherry picked from commit b4eeabb) Co-authored-by: Devin Binnie <[email protected]>
Summary
When we made the fix to disallow the
file:protocol, we started usingcreateThumbnailFromPathto process images. Unfortunately, this function is simply not defined on Linux, causing a crash.This PR falls back to using the
createFromPathfunction for Linux only, which creates a full version of the image. I've capped the image size to use at 1MB so that we don't inflate the memory usage of the downloads dropdown too much.Ticket Link
https://mattermost.atlassian.net/browse/MM-60232
Closes #3129