[MM-54584] Fixed an issue where clicking on a link to an unregistered protocol on macOS would cause the app to crash #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… protocol on macOS would cause the app to crash
hmhealey
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When calling
shell.openExternalon macOS, it returns aPromise. If the protocol used in the URL provided is not registered, the Promise will reject.We were not properly handling this rejection, and due to the changes in v5.4 that included unhandled promise rejections, the app was simply crashing even though it should just fail silently.
This PR adds the handler to catch the error, log in, and then fail silently like we would expect.
Ticket Link
https://mattermost.atlassian.net/browse/MM-54584