[MM-54591] Use getVersion endpoint to report app name #2862
Conversation
devinbinnie
added
2: Dev Review
There was a problem hiding this comment.
@devinbinnie just to understand, is this a regression from a change in 5.5? If so, can you point me to the PR so I can reference for this review?
|
There was a problem hiding this comment.
Thanks @devinbinnie! Any tests we can consider in the future for this area?
| return ( | ||
| <UpdateAvailable | ||
| item={item} | ||
| appName={appName} | ||
| /> | ||
| ); | ||
| } | ||
| if (item.state === 'completed') { | ||
| return <UpdateDownloaded item={item}/>; | ||
| return ( | ||
| <UpdateDownloaded | ||
| item={item} | ||
| appName={appName} | ||
| /> | ||
| ); |
There was a problem hiding this comment.
Not introduced in this PR but wondering why are these two cases separate? Seems they return the same thing
There was a problem hiding this comment.
One is UpdateAvailable the other is UpdateDownloaded, there are separate components.
We don't currently have front-end testing set up for Desktop App, since it wasn't creating a lot of value. |
| @@ -40,6 +41,9 @@ class DownloadsDropdown extends React.PureComponent<Record<string, never>, State | |||
| window.desktop.downloadsDropdown.focus(); | |||
| }); | |||
|
|
|||
| window.desktop.getVersion().then(({name}) => { | |||
There was a problem hiding this comment.
I'm a bit surprised to see that this works when you're removing this field in the type definition below. I guess it gets its type from somewhere else?
There was a problem hiding this comment.
It does! It's here:
Line 65 in 2a88175
devinbinnie
added
4: Reviews Complete
|
Cherry pick is scheduled. |
(cherry picked from commit 8281bbb)
mattermost-build
added
CherryPick/Done
(cherry picked from commit 8281bbb) Co-authored-by: Devin Binnie <[email protected]>
Summary
For some reason
appwasn't initialized in the preload script at the right time, causing issues that were breaking the downloads dropdown. This PR pushes us back to using the old endpoint ofgetAppVersionthat provides both the version and app name when the dropdown initializes.Ticket Link
https://mattermost.atlassian.net/browse/MM-54591