[GH-2857] Allow only macOS to call setSecureKeyboardEntryEnabled #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinbinnie
added
2: Dev Review
marianunez
approved these changes
Sep 28, 2023
Comment on lines
+152
to
+155
| if (process.platform !== 'darwin') { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Any tests we can add for this ?
There was a problem hiding this comment.
None that would add any value.
There was a problem hiding this comment.
Do we have the username/password inputs covered in E2E tests? That would be a good one to have to catch any of these type of issues in the future
There was a problem hiding this comment.
Yes many E2E tests require a login so those should be catching this.
harshilsharma63
approved these changes
Sep 28, 2023
|
@yasserfaraazkhan heads up that we are including this fix for #2857 in the upcoming dot release so we can test post-merge in the RC build. |
marianunez
added
4: Reviews Complete
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/desktop
that referenced
this pull request
Sep 28, 2023
…abled (mattermost#2860) (cherry picked from commit 2a88175)
mattermost-build
added
CherryPick/Done
marianunez
pushed a commit
that referenced
this pull request
Sep 28, 2023
…) (#2861) (cherry picked from commit 2a88175) Co-authored-by: Devin Binnie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It would appear that the
app.setSecureKeyboardEntryEnabledfunction is undefined for Windows and Linux, instead of escaped for those OSes since it doesn't affect them.This PR ensures that we only call this function for macOS.
Ticket Link
Closes #2857