[MM-54276] Stop URL from being populated on validation regardless of change/timeout #2814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
approved these changes
Aug 30, 2023
devinbinnie
requested review from
marianunez
and removed request for
M-ZubairAhmed
marianunez
approved these changes
Sep 1, 2023
devinbinnie
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On the Welcome Screen while we are validating a URL, we would always populate the returned validated URL from the main process after it was returned, regardless of whether the URL was changed in the meantime.
This PR removes the extra call that was doing that.
Ticket Link
https://mattermost.atlassian.net/browse/MM-54276
Closes #2809