[MM-54170] Automatically set the logging level to info if not specified #2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
approved these changes
Aug 30, 2023
devinbinnie
requested review from
marianunez
and removed request for
M-ZubairAhmed
marianunez
approved these changes
Sep 1, 2023
devinbinnie
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New installations did not have a default logging level set, so
electron-logwas defaulting tosillywhich was logging all keystrokes and a lot of other noise, which could fill up a user's hard drive.This PR makes sure to set the default config item to
infoand to set the log level toinfowhen the app starts by default in case the user (or some other source) removes the config item.Ticket Link
https://mattermost.atlassian.net/browse/MM-54170