[MM-53294] Fix bad user feedback on server URL validation when plugins are disabled #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-ZubairAhmed
approved these changes
Jun 22, 2023
larkox
approved these changes
Jun 23, 2023
| @@ -343,7 +343,7 @@ export class ServerViewState { | |||
| const server = new MattermostServer({name: 'temp', url: parsedURL.toString()}, false); | |||
| const serverInfo = new ServerInfo(server); | |||
| try { | |||
| const remoteInfo = await serverInfo.fetchRemoteInfo(); | |||
There was a problem hiding this comment.
Nit: this variable is no longer storing remoteInfo, but configData, so it should be renamed.
Similar in the many other places this function is called on this file.
There was a problem hiding this comment.
It actually is still storing the RemoteInfo type, it's just not necessarily complete at this point. So I think the naming is okay.
devinbinnie
added
4: Reviews Complete
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a user tries to enter a server URL that has plugins disabled, the app will tell the user that their server isn't valid, even though it is.
This PR changes the logic to not require the user of the plugins API to get the server status.
Ticket Link
https://mattermost.atlassian.net/browse/MM-53294
Closes #2766