[MM-61058] Upgrade electron-log, turn on async logging (#3173)

mattermost · Oct 23, 2024 · 97a872a · 97a872a
1 parent 9de4f6c
commit 97a872a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -168,7 +168,7 @@
     "electron-context-menu": "3.6.1",
     "electron-extension-installer": "1.2.0",
     "electron-is-dev": "2.0.0",
-    "electron-log": "5.1.1",
+    "electron-log": "5.2.0",
     "electron-updater": "6.3.0",
     "joi": "17.12.2",
     "macos-notification-state": "3.0.0",

diff --git a/src/common/log.ts b/src/common/log.ts
@@ -6,6 +6,10 @@ import log from 'electron-log';
 
 import Util from 'common/utils/util';
 
+// Turn off sync logging to prevent blocking the main thread
+// One downside to this is that some logs may not be written to the log file when the app closes
+log.transports.file.sync = false;
+
 export const setLoggingLevel = (level: string) => {
     if (log.transports.file.level === level) {
         return;