Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-52722: Fixed error when accessing property on undefined #4957

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

srisri332
Copy link

Summary

The red JavaScript banner was due an error that was occurring when a property was trying to be accessed on undefined. This undefined value occurs only when empty lines are given in the comments box. Therefore, placed a check to not do this if there are no text values in the comment box.

Testing:
check the following issue link to follow the steps to reproduce: #4831
Also, do a basic sanity test to see if the comment box functionality is working as expected.

Ticket Link

#4831
https://mattermost.atlassian.net/browse/MM-52722

@mattermost-build
Copy link
Contributor

Hello @srisri332,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants