Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent ModifiedBy overwrite #4907

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

omggga
Copy link

@omggga omggga commented Oct 18, 2023

Summary

This pull request introduces a fix to ensure that the ModifiedBy field is not overwritten if it already contains a userID. We added a conditional check to verify if the ModifiedBy field is empty before assigning a new userID, enhancing the data integrity of the block modification tracking.

By default the system uses default userID from person, who is importing data. If board.jsonl is already filled with existing IDs from current board or mattermost instance, we should accept it, not overwrite.

Ticket Link

https://community.mattermost.com/core/pl/7x9n4kfy4pbdxphsnuhtoodqxy

@mattermost-build
Copy link
Contributor

Hello @omggga,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants