Skip to content

Commit

Permalink
fix(prover): Remove unneeded dependencies, add default for graceful_s…
Browse files Browse the repository at this point in the history
…hutdown_timeout (#3242)

## What ❔

Remove unneeded dependencies.
Add default for graceful_shutdown_timeout.
<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.

ref ZKD-1855
  • Loading branch information
yorik authored Nov 8, 2024
1 parent 4509179 commit 1bfff0e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
2 changes: 0 additions & 2 deletions prover/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions prover/crates/bin/prover_autoscaler/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,8 @@ keywords.workspace = true
categories.workspace = true

[dependencies]
zksync_core_leftovers.workspace = true
zksync_vlog.workspace = true
zksync_utils.workspace = true
zksync_types.workspace = true
zksync_config = { workspace = true, features = ["observability_ext"] }
zksync_prover_job_monitor.workspace = true

Expand Down
5 changes: 4 additions & 1 deletion prover/crates/bin/prover_autoscaler/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ use zksync_config::configs::ObservabilityConfig;
#[derive(Debug, Clone, PartialEq, Deserialize)]
pub struct ProverAutoscalerConfig {
/// Amount of time ProverJobMonitor will wait all it's tasks to finish.
#[serde(with = "humantime_serde")]
#[serde(
with = "humantime_serde",
default = "ProverAutoscalerConfig::default_graceful_shutdown_timeout"
)]
pub graceful_shutdown_timeout: Duration,
pub agent_config: Option<ProverAutoscalerAgentConfig>,
pub scaler_config: Option<ProverAutoscalerScalerConfig>,
Expand Down

0 comments on commit 1bfff0e

Please sign in to comment.