fix(franklin-crypto): range check goldilocks with naive gate #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows faster interactions with repo configuration.
chore(ci): Add truflehog CI
- Fixes all the "red" errors (deny by default) observable in the monorepo. - Fixes/silences _some_ of the "yellow" errors (there are just too many for a single PR). The ultimate goal is to enable clippy in CI.
Release-As: 0.29.0
🤖 I have created a release *beep* *boop* --- ## [0.29.0](v0.28.0...v0.29.0) (2024-09-04) ### Features * **ci:** Introduce release-please and automatic publishing ([#19](#19)) ([a5444e3](a5444e3)) ### Bug Fixes * Fix hard static analysis errors ([#18](#18)) ([29f0bdd](29f0bdd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
- Renames crates with confusing/misleading names, e.g. forks with `_ce`
postfix were renamed to have `zksync_` prefix. Example: `bellman_ce` ->
`zksync_bellman`.
- Acknowledges sapling-crypto.
- Sets the unified metadata in `Cargo.toml`.
- Modifies `RELEASE.md`.
> [!WARNING]
> This is a breaking release
## Migration path
Once released, the easiest way is to modify your `Cargo.toml`, e.g.:
```
# Whether you use `bellman` or `bellman_ce`
bellman = { package = "zksync_bellman", version = "0.30.0" }
```
🤖 I have created a release *beep* *boop* --- ## [0.30.0](v0.29.0...v0.30.0) (2024-09-05) ### ⚠ BREAKING CHANGES * Rename crypto crates and properly set metadata ([#21](#21)) ### Features * Rename crypto crates and properly set metadata ([#21](#21)) ([14f44d7](14f44d7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Reverts #13 Said PR requires new VKs, so it should be processed as a part of upgrade.
🤖 I have created a release *beep* *boop* --- ## [0.30.1](v0.30.0...v0.30.1) (2024-09-05) ### Bug Fixes * **snark-wrapper:** Revert "improvement of parameters" ([#24](#24)) ([cce1da3](cce1da3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
robik75
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing range check for naive main gate that is missed during picking/dropping of previous rebase.