-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix hard static analysis errors #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
force-pushed
the
popzxc-fix-static-analysis
branch
from
August 30, 2024 08:17
6afcd04
to
47cb799
Compare
popzxc
force-pushed
the
popzxc-fix-static-analysis
branch
from
August 30, 2024 08:19
47cb799
to
73a7b75
Compare
0xVolosnikov
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, maybe crypto would like to compare benchmarks (if there are any)
@shamatar I'll proceed with merging, but will be grateful for a retrospective review! |
popzxc
pushed a commit
that referenced
this pull request
Sep 4, 2024
🤖 I have created a release *beep* *boop* --- ## [0.29.0](v0.28.0...v0.29.0) (2024-09-04) ### Features * **ci:** Introduce release-please and automatic publishing ([#19](#19)) ([a5444e3](a5444e3)) ### Bug Fixes * Fix hard static analysis errors ([#18](#18)) ([29f0bdd](29f0bdd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
saitima
pushed a commit
that referenced
this pull request
Oct 24, 2024
- Fixes all the "red" errors (deny by default) observable in the monorepo. - Fixes/silences _some_ of the "yellow" errors (there are just too many for a single PR). The ultimate goal is to enable clippy in CI.
saitima
pushed a commit
that referenced
this pull request
Oct 24, 2024
🤖 I have created a release *beep* *boop* --- ## [0.29.0](v0.28.0...v0.29.0) (2024-09-04) ### Features * **ci:** Introduce release-please and automatic publishing ([#19](#19)) ([a5444e3](a5444e3)) ### Bug Fixes * Fix hard static analysis errors ([#18](#18)) ([29f0bdd](29f0bdd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ultimate goal is to enable clippy in CI.