Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix hard static analysis errors #18

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Aug 30, 2024

  • Fixes all the "red" errors (deny by default) observable in the monorepo.
  • Fixes/silences some of the "yellow" errors (there are just too many for a single PR).

The ultimate goal is to enable clippy in CI.

Copy link

@0xVolosnikov 0xVolosnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, maybe crypto would like to compare benchmarks (if there are any)

@popzxc
Copy link
Member Author

popzxc commented Aug 30, 2024

@shamatar I'll proceed with merging, but will be grateful for a retrospective review!

@popzxc popzxc merged commit 29f0bdd into main Aug 30, 2024
5 checks passed
@popzxc popzxc deleted the popzxc-fix-static-analysis branch August 30, 2024 11:02
popzxc pushed a commit that referenced this pull request Sep 4, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.29.0](v0.28.0...v0.29.0)
(2024-09-04)


### Features

* **ci:** Introduce release-please and automatic publishing
([#19](#19))
([a5444e3](a5444e3))


### Bug Fixes

* Fix hard static analysis errors
([#18](#18))
([29f0bdd](29f0bdd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
saitima pushed a commit that referenced this pull request Oct 24, 2024
- Fixes all the "red" errors (deny by default) observable in the
monorepo.
- Fixes/silences _some_ of the "yellow" errors (there are just too many
for a single PR).

The ultimate goal is to enable clippy in CI.
saitima pushed a commit that referenced this pull request Oct 24, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.29.0](v0.28.0...v0.29.0)
(2024-09-04)


### Features

* **ci:** Introduce release-please and automatic publishing
([#19](#19))
([a5444e3](a5444e3))


### Bug Fixes

* Fix hard static analysis errors
([#18](#18))
([29f0bdd](29f0bdd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants