feat: fflonk protocol implementation #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itegulov
reviewed
Aug 29, 2024
saitima
force-pushed
the
si/fflonk
branch
2 times, most recently
from
6d26a51
to
bb72de6
Compare
saitima
force-pushed
the
si/fflonk
branch
2 times, most recently
from
2939ea4
to
2bb115c
Compare
saitima
changed the title
Allows faster interactions with repo configuration.
chore(ci): Add truflehog CI
- Fixes all the "red" errors (deny by default) observable in the monorepo. - Fixes/silences _some_ of the "yellow" errors (there are just too many for a single PR). The ultimate goal is to enable clippy in CI.
Release-As: 0.29.0
🤖 I have created a release *beep* *boop* --- ## [0.29.0](v0.28.0...v0.29.0) (2024-09-04) ### Features * **ci:** Introduce release-please and automatic publishing ([#19](#19)) ([a5444e3](a5444e3)) ### Bug Fixes * Fix hard static analysis errors ([#18](#18)) ([29f0bdd](29f0bdd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
- Renames crates with confusing/misleading names, e.g. forks with `_ce`
postfix were renamed to have `zksync_` prefix. Example: `bellman_ce` ->
`zksync_bellman`.
- Acknowledges sapling-crypto.
- Sets the unified metadata in `Cargo.toml`.
- Modifies `RELEASE.md`.
> [!WARNING]
> This is a breaking release
## Migration path
Once released, the easiest way is to modify your `Cargo.toml`, e.g.:
```
# Whether you use `bellman` or `bellman_ce`
bellman = { package = "zksync_bellman", version = "0.30.0" }
```
🤖 I have created a release *beep* *boop* --- ## [0.30.0](v0.29.0...v0.30.0) (2024-09-05) ### ⚠ BREAKING CHANGES * Rename crypto crates and properly set metadata ([#21](#21)) ### Features * Rename crypto crates and properly set metadata ([#21](#21)) ([14f44d7](14f44d7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Reverts #13 Said PR requires new VKs, so it should be processed as a part of upgrade.
🤖 I have created a release *beep* *boop* --- ## [0.30.1](v0.30.0...v0.30.1) (2024-09-05) ### Bug Fixes * **snark-wrapper:** Revert "improvement of parameters" ([#24](#24)) ([cce1da3](cce1da3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
4 tasks
saitima
added a commit
to matter-labs/zksync-protocol
that referenced
this pull request
Oct 29, 2024
This PR updates definition of the last compression step and requires 8bits grinding and also declares a version of snark-wrapper circuit that works with a constraint system that has 3 trace columns without custom gate and lookup. ### Prerequisite - [PR #11 in zksync-crypto](matter-labs/zksync-crypto#11) must be merged first to ensure compatibility and avoid breaking changes.
robik75
approved these changes
Oct 30, 2024
saitima
pushed a commit
that referenced
this pull request
Oct 30, 2024
🤖 I have created a release *beep* *boop* --- ## [0.30.4](v0.30.3...v0.30.4) (2024-10-30) ### Features * fflonk protocol implementation ([#11](#11)) ([a1485ce](a1485ce)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
saitima
added a commit
to matter-labs/zksync-crypto-gpu
that referenced
this pull request
Oct 31, 2024
# What ❔ Implements fflonk protocol for the cuda. ## Why ❔ ## Checklist - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`. ## Prerequisites - [PR matter-labs/zksync-crypto#11](matter-labs/zksync-crypto#11) - [PR #38 ] --------- Co-authored-by: Michael Carilli <[email protected]> Co-authored-by: zksync-era-bot <[email protected]> Co-authored-by: zksync-era-bot <[email protected]> Co-authored-by: Robert Remen <[email protected]> Co-authored-by: Daniyar Itegulov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements both cpu prover and verifier of fflonk protocol and convenience routines for proof compression steps.
Prerequisite