automation test coverage addition #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pcheremu can you please review this PR? |
pcheremu
approved these changes
Jan 11, 2024
vasyl-ivanchuk
approved these changes
Jan 24, 2024
pcheremu
suggested changes
Jan 25, 2024
| echo "---------------------------------" | ||
|
|
||
| echo "> zksync-cli contract write" | ||
| npx zksync-cli contract write --chain zksync-sepolia --contract 0xE6c391927f0B42d82229fd3CFe3426F209D16b48 --method "setGreeting(string _greeting) " --args "New Test ARG" --private-key 32e2e997e1a2d91cee03f77f903103ce6f50301e125307cc4bcaa87313f1a13e |
There was a problem hiding this comment.
we must not store --private-key in direct access even if it belongs to a testnet.
I will replace it to the test solution with a fix: testnet_private_key: process.env.E2E_TESTNET_PK
There was a problem hiding this comment.
process.env. --> means that it will be in git actions env. this is also not really secure but may be possible for a testnet
There was a problem hiding this comment.
Thank you! Of course make sense from security side.
pcheremu
force-pushed
the
implement-tests
branch
from
8b85a29
to
72e8084
Compare
|
#123 - latest branch with your included tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
In the scope of this PR next automation tests were added:
List of test cases automated:
Why ✋
Evidence 📷
Include screenshots, screen recordings, or
consoleoutput here demonstrating that your changes work as intendedNotes 📝