Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: command run automation #100

Merged
merged 18 commits into from
Jan 3, 2024
Merged

Conversation

pcheremu
Copy link

@pcheremu pcheremu commented Dec 5, 2023

What 💻

  • added a workflow to run tests in GH actions
  • added a bash script to emulate user input for zksync-cli commands

Why ✋

GH workflow will run the script on 3 supported platforms
the script will contains set of tests to cover an essential functionality

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

Notes 📝

  • Any notes/thoughts that the reviewers should know prior to reviewing the code?

@pcheremu pcheremu added the automation autotests \ QA tests label Dec 5, 2023
@pcheremu pcheremu self-assigned this Dec 5, 2023
@pcheremu pcheremu requested a review from a team as a code owner December 5, 2023 15:10


jobs:
cli_test_linux_amd64:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd re-do that from the matrix perspective.

@@ -0,0 +1,31 @@
name: Call the CLI testing

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need two *.yaml files here?

Does that make sense to combine them into the one?

@@ -0,0 +1,140 @@
#!/bin/bash

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those test scenarios related to the testing docs?
If it really is, does that make sense to add some relation testing docs-script?

Copy link

@abilevych abilevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@JackHamer09 can you please take a look as well?

@pcheremu pcheremu force-pushed the QA-560-zksync-cli-automation branch from 2d68bcd to 82d5d76 Compare January 3, 2024 12:53
@pcheremu pcheremu changed the base branch from main to implement-tests January 3, 2024 13:32
@pcheremu pcheremu merged commit 8b85a29 into implement-tests Jan 3, 2024
8 checks passed
@pcheremu pcheremu deleted the QA-560-zksync-cli-automation branch January 3, 2024 13:38
pcheremu added a commit that referenced this pull request Feb 8, 2024
pcheremu added a commit that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation autotests \ QA tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants