-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: command run automation #100
Conversation
.github/workflows/run-test-cli.yml
Outdated
|
||
|
||
jobs: | ||
cli_test_linux_amd64: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd re-do that from the matrix perspective.
.github/workflows/run-test-cli.yml
Outdated
@@ -0,0 +1,31 @@ | |||
name: Call the CLI testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need two *.yaml files here?
Does that make sense to combine them into the one?
@@ -0,0 +1,140 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those test scenarios related to the testing docs?
If it really is, does that make sense to add some relation testing docs-script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@JackHamer09 can you please take a look as well?
2d68bcd
to
82d5d76
Compare
What 💻
Why ✋
GH workflow will run the script on 3 supported platforms
the script will contains set of tests to cover an essential functionality
Evidence 📷
Include screenshots, screen recordings, or
console
output here demonstrating that your changes work as intendedNotes 📝