fix: check node version

matter-labs · Oct 16, 2023 · e93b952 · e93b952
1 parent f336dd9
commit e93b952
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/src/program.ts b/src/program.ts
@@ -18,10 +18,14 @@ program.name(Package.name).description(Package.description).version(Package.vers
 program.hook("preAction", async () => {
   const nodeVersion = await getNodeVersion();
   const minimumNodeVersion = "18.0.0";
-  if (compare(nodeVersion, minimumNodeVersion, "<")) {
-    Logger.error("Minimum Node.js version required: v18.x");
-    Logger.error(`Current version: v${nodeVersion}`);
-    process.exit(1);
+  try {
+    if (compare(nodeVersion, minimumNodeVersion, "<")) {
+      Logger.error("Minimum Node.js version required: v18.x");
+      Logger.error(`Current version: v${nodeVersion}`);
+      process.exit(1);
+    }
+  } catch (error) {
+    Logger.warn(`Failed to check Node.js version. Make sure you are using version ${minimumNodeVersion} or higher`);
   }
 });
 

diff --git a/src/utils/node.ts b/src/utils/node.ts
@@ -5,9 +5,12 @@ let nodeVersion: string | undefined;
 export const getNodeVersion = async () => {
   if (nodeVersion) return nodeVersion;
   try {
-    const version = await executeCommand("node --version", { silent: true });
-    nodeVersion = version.trim().slice(1);
-    return nodeVersion;
+    const version = (await executeCommand("node --version", { silent: true })).trim();
+    const vIndex = version.indexOf("v");
+    if (vIndex === -1) {
+      return version;
+    }
+    return version.slice(vIndex + 1);
   } catch {
     throw new Error("Node.js is not installed. Download: http://nodejs.org");
   }