-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve variety of chains sync layer stable #818
Merged
StanislavBreadless
merged 6 commits into
sync-layer-stable
from
sb-improve-variety-of-chains-sync-layer-stable
Sep 23, 2024
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
42d47fe
make validium work
StanislavBreadless 4cc2a36
fmt
StanislavBreadless bc04c53
fix import
StanislavBreadless 010ed90
import bytecode differently
StanislavBreadless df00c73
l2 testnet verifier
StanislavBreadless a8bf0ca
fix lint
StanislavBreadless File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
// SPDX-License-Identifier: MIT | ||
|
||
pragma solidity 0.8.24; | ||
|
||
import {Verifier} from "./Verifier.sol"; | ||
import {IVerifier} from "./chain-interfaces/IVerifier.sol"; | ||
|
||
/// @author Matter Labs | ||
/// @custom:security-contact [email protected] | ||
/// @notice Modified version of the main verifier contract for the testnet environment | ||
/// @dev This contract is used to skip the zkp verification for the testnet environment. | ||
/// If the proof is not empty, it will verify it using the main verifier contract, | ||
/// otherwise, it will skip the verification. | ||
contract TestnetVerifier is Verifier { | ||
constructor(uint256 _l1ChainId) { | ||
assert(_l1ChainId != 1); | ||
} | ||
|
||
/// @dev Verifies a zk-SNARK proof, skipping the verification if the proof is empty. | ||
/// @inheritdoc IVerifier | ||
function verify(uint256[] calldata _publicInputs, uint256[] calldata _proof) public view override returns (bool) { | ||
// We allow skipping the zkp verification for the test(net) environment | ||
// If the proof is not empty, verify it, otherwise, skip the verification | ||
if (_proof.length == 0) { | ||
return true; | ||
} | ||
|
||
return super.verify(_publicInputs, _proof); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we still need the ts scripts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For hardhat tests