Packed protocol version #492

StanislavBreadless · 2024-05-24T06:36:20Z

What ❔

Storing protocolVersion as a packed semver value.

Two potential improvements:

Store it as struct in storage. It gives us more explicit description of what it is. However it causes a much bigger diff code and generally packing will still be needed for the protocolVersionDeadline map in STM.
Store it as 100 * minor + patch. It is more human readable, but not "standard", though we can consider it due to better usability

Fixes: EVM-637

Why ❔

Checklist

PR title corresponds to the body of PR (we generate changelog entries from PRs).
Tests for the changes have been added / updated.
Documentation comments have been added / updated.

l1-contracts/contracts/state-transition/chain-interfaces/IGetters.sol

l1-contracts/contracts/upgrades/BaseZkSyncUpgrade.sol

l1-contracts/contracts/state-transition/IStateTransitionManager.sol

l1-contracts/contracts/upgrades/BaseZkSyncUpgrade.sol

l1-contracts/scripts/utils.ts

l1-contracts/contracts/common/Config.sol

…n getters

vladbochok

@StanislavBreadless We firstly need to bump protocol version and then start using this contract, right?

l1-contracts/contracts/common/libraries/SemVer.sol

l1-contracts/contracts/state-transition/IStateTransitionManager.sol

Co-authored-by: Vlad Bochok <[email protected]>

Use `CONTRACTS_GENESIS_PROTOCOL_SEMANTIC_VERSION` variable

… sb-packed-protocol-version

l1-contracts/contracts/upgrades/BaseZkSyncUpgrade.sol

Co-authored-by: perekopskiy <[email protected]>

l1-contracts/contracts/upgrades/BaseZkSyncUpgrade.sol

vladbochok

Please fix slither

Co-authored-by: perekopskiy <[email protected]> Co-authored-by: Vlad Bochok <[email protected]> Co-authored-by: perekopskiy <[email protected]>

StanislavBreadless added 3 commits May 23, 2024 16:47

semver for protocol version

3e27dd2

adapt to work with server

5c61a50

fmt

504ddbf

perekopskiy reviewed May 24, 2024

View reviewed changes

l1-contracts/contracts/state-transition/chain-interfaces/IGetters.sol Outdated Show resolved Hide resolved

l1-contracts/contracts/upgrades/BaseZkSyncUpgrade.sol Outdated Show resolved Hide resolved

StanislavBreadless added 5 commits May 24, 2024 11:31

add better checks

cd2258f

cleanup + stricter rules

d67d456

lint fix

71c43d0

docs

d8def78

semver getter for STM

8a28eb6

vladbochok reviewed May 24, 2024

View reviewed changes

l1-contracts/contracts/state-transition/IStateTransitionManager.sol Show resolved Hide resolved

vladbochok reviewed May 24, 2024

View reviewed changes

l1-contracts/contracts/upgrades/BaseZkSyncUpgrade.sol Show resolved Hide resolved

vladbochok reviewed May 24, 2024

View reviewed changes

l1-contracts/scripts/utils.ts Outdated Show resolved Hide resolved

vladbochok reviewed May 24, 2024

View reviewed changes

l1-contracts/contracts/common/Config.sol Outdated Show resolved Hide resolved

vladbochok reviewed May 24, 2024

View reviewed changes

l1-contracts/contracts/common/Config.sol Outdated Show resolved Hide resolved

restore hardhat unit tests + change how we display protocol version i…

cc45658

…n getters

vladbochok reviewed May 24, 2024

View reviewed changes

l1-contracts/contracts/common/libraries/SemVer.sol Outdated Show resolved Hide resolved

l1-contracts/contracts/state-transition/IStateTransitionManager.sol Show resolved Hide resolved

perekopskiy and others added 7 commits May 24, 2024 14:29

Use new variable

f050432

Update l1-contracts/contracts/common/Config.sol

61d4e39

Co-authored-by: Vlad Bochok <[email protected]>

respond to some comments

8fa6d1b

sync with upstream

0f3b853

Merge pull request #493 from matter-labs/mp-use-new-var-in-scripts

004bb38

Use `CONTRACTS_GENESIS_PROTOCOL_SEMANTIC_VERSION` variable

update lib + safecast

87ac548

Merge remote-tracking branch 'origin/sb-packed-protocol-version' into…

cf215f1

… sb-packed-protocol-version

StanislavBreadless requested review from vladbochok and perekopskiy May 24, 2024 11:43

perekopskiy reviewed May 24, 2024

View reviewed changes

l1-contracts/contracts/upgrades/BaseZkSyncUpgrade.sol Outdated Show resolved Hide resolved

StanislavBreadless and others added 2 commits May 24, 2024 14:08

add test for migration to the new version

9f8144e

Update l1-contracts/contracts/upgrades/BaseZkSyncUpgrade.sol

d92a34d

Co-authored-by: perekopskiy <[email protected]>

StanislavBreadless requested a review from perekopskiy May 24, 2024 12:09

StanislavBreadless marked this pull request as ready for review May 24, 2024 12:10

StanislavBreadless added 6 commits May 24, 2024 14:14

spellcheck

c566f89

lint fix

579d813

better test coverage for upgrade

06e3466

cover with more tests

1b11605

typos

7f184bf

add a todo for future

e255f91

perekopskiy approved these changes May 24, 2024

View reviewed changes

fixes

25d90f9

vladbochok reviewed May 24, 2024

View reviewed changes

l1-contracts/contracts/upgrades/BaseZkSyncUpgrade.sol Show resolved Hide resolved

vladbochok approved these changes May 24, 2024

View reviewed changes

StanislavBreadless added 2 commits May 24, 2024 17:39

resolve nit

9647526

fix slither

5f074a8

StanislavBreadless merged commit 8cc766e into release-v23 May 29, 2024
22 of 23 checks passed

StanislavBreadless deleted the sb-packed-protocol-version branch May 29, 2024 09:07

Raid5594 pushed a commit that referenced this pull request May 30, 2024

Packed protocol version (#492)

ac8ac7c

Co-authored-by: perekopskiy <[email protected]> Co-authored-by: Vlad Bochok <[email protected]> Co-authored-by: perekopskiy <[email protected]>

Raid5594 pushed a commit that referenced this pull request May 30, 2024

Packed protocol version (#492)

01487d4

Co-authored-by: perekopskiy <[email protected]> Co-authored-by: Vlad Bochok <[email protected]> Co-authored-by: perekopskiy <[email protected]>

Raid5594 pushed a commit that referenced this pull request May 30, 2024

Packed protocol version (#492)

7c278f0

Co-authored-by: perekopskiy <[email protected]> Co-authored-by: Vlad Bochok <[email protected]> Co-authored-by: perekopskiy <[email protected]>

Deniallugo pushed a commit that referenced this pull request Jul 25, 2024

Packed protocol version (#492)

4da9829

Co-authored-by: perekopskiy <[email protected]> Co-authored-by: Vlad Bochok <[email protected]> Co-authored-by: perekopskiy <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Packed protocol version #492

Packed protocol version #492

StanislavBreadless commented May 24, 2024 •

edited by mm-zk

Loading

vladbochok left a comment

vladbochok left a comment

Packed protocol version #492

Packed protocol version #492

Conversation

StanislavBreadless commented May 24, 2024 • edited by mm-zk Loading

What ❔

Why ❔

Checklist

vladbochok left a comment

Choose a reason for hiding this comment

vladbochok left a comment

Choose a reason for hiding this comment

StanislavBreadless commented May 24, 2024 •

edited by mm-zk

Loading