fix linting #486
Merged
fix linting #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raid5594
commented
May 22, 2024
Raid5594
commented
May 22, 2024
|
|
||
| // Note that we don't save the deposited amount, as this is for the base token, which gets sent to the refundRecipient if the tx fails | ||
| emit BridgehubDepositBaseTokenInitiated(_chainId, _prevMsgSender, _assetInfo, _amount); | ||
| // We could use this data instead of the above | ||
| // emit BridgehubMintData(bridgeMintData); |
There was a problem hiding this comment.
There's probably a better way to use this data
There was a problem hiding this comment.
We can emit the event in the L1StandardAsset, no? We could emit the data hash though. What do you recommend?
There was a problem hiding this comment.
I think it's more cohesive if we have events in sharedbridge, so we're indexing in 1 place
By the way, do we need to add l2Receiver in L1NTV?
I would actually not create any variable in memory to make the call more efficient.
If we have everything we need, then just suppress the other linting error (unused return value)
kelemeno
added a commit
that referenced
this pull request
May 22, 2024
Co-authored-by: Raid Ateir <[email protected]> Co-authored-by: kelemeno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist