feat: migrate to use zkforge artifacts #471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanislavBreadless
requested changes
May 20, 2024
| @@ -17,7 +17,7 @@ import {IPubdataChunkPublisher} from "./interfaces/IPubdataChunkPublisher.sol"; | |||
|
|
|||
| /// @dev All the system contracts introduced by zkSync have their addresses | |||
| /// started from 2^15 in order to avoid collision with Ethereum precompiles. | |||
| uint160 constant SYSTEM_CONTRACTS_OFFSET = {{SYSTEM_CONTRACTS_OFFSET}}; // 2^15 | |||
| uint160 constant SYSTEM_CONTRACTS_OFFSET = 32768; // 2^15 | |||
There was a problem hiding this comment.
This PR changes the hash of the system contract most likely because of this change.
- We need this preprocessing to run unit tests for system contracts (as you can see, the tests fail now)
- The hashes for system contracts change (making this PR not okay for the
release-*branch, but more suitable fordevone where non stable changes are allowed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔