Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Evm equivalence in yul #364

Closed
wants to merge 691 commits into from
Closed

feat: Evm equivalence in yul #364

wants to merge 691 commits into from

Conversation

jrchatruc
Copy link
Contributor

What ❔

This PR adds an EVM Yul Interpreter on top of the already existing Solidity EVM Interpreter effort

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@jrchatruc jrchatruc changed the base branch from main to dev April 15, 2024 14:28
@jrchatruc jrchatruc changed the base branch from dev to sb-1-5-0-evm-eq-integration April 16, 2024 15:50
ManuelBilbao and others added 28 commits April 29, 2024 12:36
@ManuelBilbao @jrchatruc
Replace expression with already calculated variable
ef4111f
@ManuelBilbao @jrchatruc
Charge gas on mload and mstore
6658425
@ManuelBilbao @jrchatruc
Add mstore8 opcode
59765af
@ManuelBilbao @jrchatruc
Charge gas on mstore8
8cb0a5a
@ManuelBilbao @jrchatruc
Move memory expansion to function
4094115
@jrchatruc
Add memory expansion function
b04c5a9
@ManuelBilbao @jrchatruc
Improve legibility
3e79894
@ManuelBilbao @jrchatruc
Fix exponent gas charge
97c0a4e
@ManuelBilbao
Refactor returndatacopy opcode
72d2bb4
@fborello-lambda @jrchatruc
feat(blockenvironment-opcodes): Add opcodes
bd54bec 
blob opcodes are commented

the current compiler can't build the contract
@fborello-lambda @jrchatruc
refactor(blockenvironment-opcodes): Remove blob opcodes
30a966d
@ManuelBilbao @jrchatruc
Start working on create opcode
67c4cc4
@ManuelBilbao @jrchatruc
Get deployed address for create
40583b3
@ManuelBilbao @jrchatruc
Fix bytes encoding
9a059c8
@ManuelBilbao @jrchatruc
Add sample init code
779f325
@jrchatruc
Add basic constructor code
7b9c987
@jrchatruc
Add correct bytecode when creating
6323174
@jrchatruc
Fix isStatic check when constructor is called
ac9bddd
@ManuelBilbao @jrchatruc
Remove logs
e0a53ac
@ManuelBilbao @jrchatruc
Format code
2bdca4a
@ManuelBilbao @jrchatruc
Implement gas functions for constructor fallback
d7dc722
@ManuelBilbao @jrchatruc
Use real calldata from user
578993f
@ManuelBilbao @jrchatruc
Allow nonces greater than 128
831cece
@ManuelBilbao @jrchatruc
Fix addresses masks
47e4c11
@ManuelBilbao @jrchatruc
Replicate create opcode on constructor
45915e2
@ManuelBilbao @jrchatruc
Increment nonce after a create
7cd0f73
@ManuelBilbao @jrchatruc
Add more validations
58e73c6
@ManuelBilbao @jrchatruc
Replicate create opcode on constructor
6cf623e
@vladimirradosavljevic
Implement memcpy function
40d84fd 
Instead of using loop to store bytes for OP_CODECOPY,
call optimized memcpy function.

Signed-off-by: Vladimir Radosavljevic <[email protected]>
@vladimirradosavljevic
Remove calls to mstore8 in OP_MCOPY and fix checks
e4175ac 
Instead, call mcopy that is is essentially
optimized implementation of memmove. Add
checks for memory overflow.

This patch is a joint work by:
Gianbelinche <[email protected]>
Vladimir Radosavljevic <[email protected]>

Signed-off-by: Vladimir Radosavljevic <[email protected]>
@0xVolosnikov
Check offset overflow earlier in memory opcodes
1b2b0f9
@jrchatruc
Merge pull request #705 from matter-labs/vv-evm-interp-mem-overflow-c…
462f011 
…heck

[EVM-Equivalence-YUL] Check offset overflow earlier in memory opcodes
@0xVolosnikov
Remove pop push check
d272a7e
@0xVolosnikov
Use unchecked push in safe cases
3d766a2
@0xVolosnikov
Execute JUMPDEST immediately after JUMP/JUMPI
6691c88
@jrchatruc
Merge pull request #713 from matter-labs/vv-optimize-jump
c8bdc79 
[EVM-Equivalence-YUL] Execute JUMPDEST immediately after JUMP/JUMPI
@jrchatruc
Merge pull request #710 from matter-labs/vv-remove-pop-push-check
68a2c6a 
[EVM-Equivalence-YUL] Remove pop push check
@jrchatruc
Merge pull request #689 from vladimirradosavljevic/remove_mstore8_calls
36c03ec 
[EVM-Equivalence-YUL] Remove calls to mstore8
@jrchatruc
Merge pull request #677 from lambdaclass/dont-charge-the-regular-cost…
74767c1 
…-of-calls-for-precompiles

[EVM Equivalence in Yul] fix: Don't charge the regular cost of the call when calling precompiles
@gianbelinche
Remove TODOs
77eb854
@jrchatruc
Merge pull request #723 from lambdaclass/remove-todo
18d1d3a 
[EVM-Equivalence-YUL] Remove TODOs
@0xVolosnikov
Use switch/case in calls
7356c2c
@0xVolosnikov
Fix
2611e61
@0xVolosnikov
Optimize getNewAddress
fefa6ce
@0xVolosnikov
Add and use pushStackCheck
7a98198
@0xVolosnikov
Initial overflow checks remake
83d9aa7
@0xVolosnikov
Merge branch 'evm-equivalence-yul' into vv-small-interpreter-optimiza…
2c9b719 
…tions
@jrchatruc
Merge pull request #729 from matter-labs/vv-small-interpreter-optimiz…
5cdc5dd 
…ations

[EVM-Equivalence-YUL] Interpeter optimizations
@0xVolosnikov
Implement evmCodeHash without mapping (no need to keccak key)
944b6c9
@0xVolosnikov
Simplify _fetchDeployedCodeLen
89245ad
@0xVolosnikov
Use _fetchDeployedCodeLen for both code types
448bc97
@gianbelinche @IAvecilla @jrchatruc
[EVM-Equivalence-YUL] Restrict functions to only be called from inter…
253d370 
…preter (#745)

Co-authored-by: IAvecilla <[email protected]>
Co-authored-by: Javier Chatruc <[email protected]>
@jrchatruc
Merge pull request #752 from matter-labs/vv-evm-simplify-fetchDeploye…
2fe0652 
…dCodeLen

[EVM-Equivalence-YUL] Simplify EXTCODESIZE
@jrchatruc
Merge pull request #751 from matter-labs/vv-evm-simplify-evmCodeHash
b022c9b 
[EVM-Equivalence-YUL] Implement evmCodeHash without mapping
@jrchatruc
Copy link
Contributor Author

Closed in favor of #685

@jrchatruc jrchatruc closed this Sep 17, 2024
@jrchatruc jrchatruc mentioned this pull request Sep 25, 2024
Closed
3 tasks
@0xVolosnikov 0xVolosnikov deleted the evm-equivalence-yul branch September 27, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladbochok vladbochok Awaiting requested review from vladbochok vladbochok will be requested when the pull request is marked ready for review vladbochok is a code owner

@StanislavBreadless StanislavBreadless Awaiting requested review from StanislavBreadless StanislavBreadless will be requested when the pull request is marked ready for review StanislavBreadless is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jrchatruc @ManuelBilbao @fborello-lambda @gianbelinche @fkrause98 @IAvecilla @vladimirradosavljevic @StanislavBreadless @0xVolosnikov