-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slither for l1 contracts #280
Conversation
@StanislavBreadless as we discussed with @vladbochok could you please review the following findings
and let us know how we should proceed. Should it be fixed or ignored? If fixed, then could you add a fix into this PR? |
@dnkolegov we can ignore it. If we used what slither proposed, the calculations would indeed be slightly more precise, but IMHO the way it is now is a bit easier to read & reuse (i.e. whenever we need l1 gas price we can use |
Co-authored-by: Stanislav Bezkorovainyi <[email protected]>
Co-authored-by: Stanislav Bezkorovainyi <[email protected]>
What ❔
This PR enables the slither static analyzer for L1 contracts and also resolves the issues it has found.
It is configured to catch high- and medium-severity potential issues.
It doesn't check
Verifier.sol
contract.The PR also documents how to deal with findings.
Why ❔
To find "low-hanging fruits" bugs and known vulnerabilities.
Checklist