System contracts CI

WIP: migration on top of L2 #1745

Sign in to view logs

Triggered via pull request May 21, 2024 13:58

StanislavBreadless

synchronize #459

sb-sync-layer-migration

Status Failure

Total duration 23m 55s

Artifacts –

system-contracts-ci.yaml

on: pull_request

test-bootloader

Annotations

20 errors and 24 warnings

lint: l1-contracts/contracts/state-transition/chain-deps/facets/Admin.sol#L8

imported name StoredBatchHashInfo is not used

lint: l1-contracts/contracts/state-transition/chain-deps/facets/Admin.sol#L282

Named parameters missing. MIN unnamed argumenst is 4

lint: l1-contracts/contracts/state-transition/chain-deps/facets/Executor.sol#L667

Variable "_index" is unused

lint: l1-contracts/contracts/state-transition/chain-interfaces/IAdmin.sol#L8

imported name TxStatus is not used

lint: l1-contracts/contracts/state-transition/IStateTransitionManager.sol#L6

imported name L2CanonicalTransaction is not used

lint: l1-contracts/contracts/state-transition/StateTransitionManager.sol#L7

imported name L2TransactionRequestTwoBridgesOuter is not used

lint: l1-contracts/contracts/state-transition/StateTransitionManager.sol#L7

imported name L2TransactionRequestTwoBridgesInner is not used

lint: l1-contracts/contracts/state-transition/StateTransitionManager.sol#L12

imported name IDefaultUpgrade is not used

lint: l1-contracts/contracts/state-transition/StateTransitionManager.sol#L16

imported name ISystemContext is not used

lint: l1-contracts/contracts/state-transition/StateTransitionManager.sol#L19

imported name L2_SYSTEM_CONTEXT_SYSTEM_CONTRACT_ADDR is not used

lint: l1-contracts/contracts/state-transition/chain-deps/facets/Admin.sol#L8

imported name StoredBatchHashInfo is not used

lint: l1-contracts/contracts/state-transition/chain-deps/facets/Admin.sol#L282

Named parameters missing. MIN unnamed argumenst is 4

lint: l1-contracts/contracts/state-transition/chain-deps/facets/Executor.sol#L667

Variable "_index" is unused

lint: l1-contracts/contracts/state-transition/chain-interfaces/IAdmin.sol#L8

imported name TxStatus is not used

lint: l1-contracts/contracts/state-transition/IStateTransitionManager.sol#L6

imported name L2CanonicalTransaction is not used

lint: l1-contracts/contracts/state-transition/StateTransitionManager.sol#L7

imported name L2TransactionRequestTwoBridgesOuter is not used

lint: l1-contracts/contracts/state-transition/StateTransitionManager.sol#L7

imported name L2TransactionRequestTwoBridgesInner is not used

lint: l1-contracts/contracts/state-transition/StateTransitionManager.sol#L12

imported name IDefaultUpgrade is not used

lint: l1-contracts/contracts/state-transition/StateTransitionManager.sol#L16

imported name ISystemContext is not used

lint: l1-contracts/contracts/state-transition/StateTransitionManager.sol#L19

imported name L2_SYSTEM_CONTEXT_SYSTEM_CONTRACT_ADDR is not used

check-hashes

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, actions/cache/restore@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, actions/cache/save@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

lint: l1-contracts/contracts/state-transition/chain-deps/facets/Mailbox.sol#L288

Avoid to use tx.origin

lint: l1-contracts/contracts/upgrades/Upgrade_v1_4_1.sol#L11

Contract name must be in CamelCase

lint: l1-contracts/contracts/vendor/AddressAliasHelper.sol#L55

Avoid to use tx.origin

lint: l1-contracts/test/foundry/unit/concrete/AddressAliasHelper/applyL1ToL2Alias.t.sol#L6

Contract name must be in CamelCase

lint: l1-contracts/test/foundry/unit/concrete/AddressAliasHelper/undoL1ToL2Alias.t.sol#L6

Contract name must be in CamelCase

lint: l1-contracts/test/foundry/unit/concrete/Executor/ExecutorProof.t.sol#L2

Found more than One contract per file. 2 contracts found!

lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/DiamondProxy/DiamondProxy.t.sol#L2

Found more than One contract per file. 2 contracts found!

lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/facets/Admin/ExecuteUpgrade.t.sol#L3

Found more than One contract per file. 2 contracts found!

lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/facets/Base/_Base_Shared.t.sol#L2

Found more than One contract per file. 2 contracts found!

lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/facets/Getters/_Getters_Shared.t.sol#L2

Found more than One contract per file. 2 contracts found!

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

lint: l1-contracts/contracts/state-transition/chain-deps/facets/Mailbox.sol#L288

Avoid to use tx.origin

lint: l1-contracts/contracts/upgrades/Upgrade_v1_4_1.sol#L11

Contract name must be in CamelCase

lint: l1-contracts/contracts/vendor/AddressAliasHelper.sol#L55

Avoid to use tx.origin

lint: l1-contracts/test/foundry/unit/concrete/AddressAliasHelper/applyL1ToL2Alias.t.sol#L6

Contract name must be in CamelCase

lint: l1-contracts/test/foundry/unit/concrete/AddressAliasHelper/undoL1ToL2Alias.t.sol#L6

Contract name must be in CamelCase

lint: l1-contracts/test/foundry/unit/concrete/Executor/ExecutorProof.t.sol#L2

Found more than One contract per file. 2 contracts found!

lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/DiamondProxy/DiamondProxy.t.sol#L2

Found more than One contract per file. 2 contracts found!

lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/facets/Admin/ExecuteUpgrade.t.sol#L3

Found more than One contract per file. 2 contracts found!

lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/facets/Base/_Base_Shared.t.sol#L2

Found more than One contract per file. 2 contracts found!

lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/facets/Getters/_Getters_Shared.t.sol#L2

Found more than One contract per file. 2 contracts found!