Skip to content
System contracts CI

fix L2 tests #1720

Sign in to view logs

fix L2 tests

fix L2 tests #1720

Triggered via pull request May 17, 2024 12:46
@Raid5594Raid5594
opened #478
ra/update-sync-layer-reorg
Status Failure
Total duration 2m 43s
Artifacts –

system-contracts-ci.yaml

on: pull_request
build
1m 56s
build
lint
47s
lint
check-hashes
28s
check-hashes
test-bootloader
0s
test-bootloader
test-contracts
0s
test-contracts
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 13 warnings
lint: l1-contracts/contracts/bridge/interfaces/IL1NativeTokenVault.sol#L5
imported name L2TransactionRequestTwoBridgesInner is not used
lint: l1-contracts/contracts/bridge/L1NativeTokenVault.sol#L17
imported name TWO_BRIDGES_MAGIC_VALUE is not used
lint: l1-contracts/contracts/bridge/L1NativeTokenVault.sol#L19
imported name IBridgehub is not used
lint: l1-contracts/contracts/bridge/L1NativeTokenVault.sol#L19
imported name L2TransactionRequestTwoBridgesInner is not used
lint: l1-contracts/contracts/bridge/L1NativeTokenVault.sol#L19
imported name L2TransactionRequestDirect is not used
lint: l1-contracts/contracts/bridge/L1NativeTokenVault.sol#L91
Variable "_mintValue" is unused
lint: l1-contracts/contracts/bridge/L1NativeTokenVault.sol#L117
Named parameters missing. MIN unnamed argumenst is 4
lint: l1-contracts/contracts/bridge/L1NativeTokenVault.sol#L146
Variable "_chainId" is unused
lint: l1-contracts/contracts/bridge/L1NativeTokenVault.sol#L170
Variable "_prevMsgSender" is unused
lint: l1-contracts/contracts/bridge/L1SharedBridge.sol#L8
imported name IERC20Metadata is not used
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
lint: l1-contracts/contracts/state-transition/chain-deps/facets/Mailbox.sol#L339
Avoid to use tx.origin
lint: l1-contracts/contracts/upgrades/Upgrade_v1_4_1.sol#L11
Contract name must be in CamelCase
lint: l1-contracts/contracts/vendor/AddressAliasHelper.sol#L55
Avoid to use tx.origin
lint: l1-contracts/test/foundry/unit/concrete/AddressAliasHelper/applyL1ToL2Alias.t.sol#L6
Contract name must be in CamelCase
lint: l1-contracts/test/foundry/unit/concrete/AddressAliasHelper/undoL1ToL2Alias.t.sol#L6
Contract name must be in CamelCase
lint: l1-contracts/test/foundry/unit/concrete/Executor/ExecutorProof.t.sol#L2
Found more than One contract per file. 2 contracts found!
lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/DiamondProxy/DiamondProxy.t.sol#L2
Found more than One contract per file. 2 contracts found!
lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/facets/Admin/ExecuteUpgrade.t.sol#L3
Found more than One contract per file. 2 contracts found!
lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/facets/Base/_Base_Shared.t.sol#L2
Found more than One contract per file. 2 contracts found!
lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/facets/Getters/_Getters_Shared.t.sol#L2
Found more than One contract per file. 2 contracts found!
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, actions/cache/save@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
check-hashes
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, actions/cache/restore@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.